New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative URIs with absolute paths are not resolved correctly #521
Labels
Milestone
Comments
boushley
added a commit
to boushley/dash.js
that referenced
this issue
Jan 15, 2016
This should resolve Dash-Industry-Forum#521.
It seems that this issue was re-introduced by 2328620 |
Confirmed. |
@TalLevAmi I believe davemevans@c7efeb6 should address this. Please could you try applying that and report back? If so, I'll create a PR. |
@bbcrddave Confirmed it works. Thanks for the quick response! |
dsparacio
pushed a commit
that referenced
this issue
Jul 6, 2016
Fix #521 - properly support path-absolute BaseURLs
marcoslhc
added a commit
to veo-televisa/dash.js
that referenced
this issue
Jul 19, 2016
… into DC-7-create-test-cases-for-blim-env * 'master' of https://github.com/Dash-Industry-Forum/dash.js: (97 commits) adding dist files to master Adding release notes to Reference player. Adding release notes to Reference player. Fix Dash-Industry-Forum#521 - properly support path-absolute BaseURLs Revert "For SegmentTemplate, only include available segments in DVRInfo" fix Dash-Industry-Forum#1463 - update documentation for setScheduleWhilePaused use sidx exclusively if there is an indexRange - thanks @bwidtmann Enable SegmentTimeline within SegmentList ManifestModel setValue should not trigger MANIFEST_LOADED when reset Update ISSUE_TEMPLATE.md Dash-Industry-Forum#1145 cleanup protection log Fix for issue Dash-Industry-Forum#887 Removed build artifacts Reverted grunt changes Added support for filtering out key systems when no protection data for that key system is present fixed audio only buffer targets for longform etc... added missing comma fix for failing end test in browserstack Dash-Industry-Forum#1445 add a robustness level capabilities configuration for the protection controller. This is optional for Widevine Chrome to prevent robustness level warnings. remove check on required quality / check not needed anymore. See Dash-Industry-Forum#1443 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A relative URI that starts with a
/
is not parsed correctly. It should replace the path component of its context, but in dash.js it is appended to the directory component of the context URL.These relative URIs are specified in RFC 3986 as "path-absolute".
For example serving the MPD below from
/MPDs/baseurl.mpd
results in dash.js requesting/MPDs//path/at/root/video_900000bps.mp4
when it should be requesting/path/at/root/video_900000bps.mp4
.A similar test can be constructed with
BaseURL
elements in nested scope, each with an absolute path.The text was updated successfully, but these errors were encountered: