Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live audio-only stream show incorrect time info #887

Closed
yancey918 opened this issue Nov 14, 2015 · 8 comments
Closed

Live audio-only stream show incorrect time info #887

yancey918 opened this issue Nov 14, 2015 · 8 comments
Assignees
@dsparacio
Labels
Bug Pri-High
Milestone
2.2.0

Comments

@yancey918
Copy link

Dear Sir ,
Why the live stream time info always show 00:00 ?
http://54.179.140.239:1935/live/livestream/manifest.mpd - neither the dash.js sample player (http://dashif.org/reference/players/javascript/v1.5.1/samples/dash-if-reference-player/index.html) nor the Akamai player(http://mediapm.edgesuite.net/dash/public/support-player/current/index.html) shows any time info.
*note) stream server is WOWZA (Engine 4.3.0 build16025)
image
This was referenced Nov 14, 2015
Closed
Closed
@davemevans
Copy link
Contributor

This issue only affects audio-only streams.

There is an incorrect assumption in MediaPlayer.getDVRInfoMetric which assumes that there will be no metrics for video for an audio-only stream. This is incorrect - metrics will always be returned for video, but there will be no DVRInfo in the video metrics if there is no video.

This assumption is also made in PlaybackController.getActualPresentationTime.

@davemevans
Copy link
Contributor

Note that if you use an <audio> tag rather than a <video> tag, everything works as you would expect.

This was referenced Nov 23, 2015
Closed
Closed
@dsparacio
Copy link
Contributor

@bbcrddave this is still valid issue correct?

@dsparacio dsparacio added the Bug label Feb 24, 2016
@davemevans
Copy link
Contributor

Correct. It's because support for detecting droppedFrames is available when using <video>. This causes a video metrics to be created. which leads to the behaviour above.

I had a look a while ago and determined there wasn't a pretty solution. Perhaps we could move the DVRInfo metric into the stream mediaType: it's not clear to me why audio and video need a different set - shouldn't the segment availability be the same for all segment types? This would involve some refactoring.

@dsparacio dsparacio added this to the 2.1.0 milestone Feb 24, 2016
@dsparacio dsparacio self-assigned this Mar 3, 2016
@dsparacio dsparacio modified the milestones: 2.2.0, 2.1.0 Apr 25, 2016
@dsparacio dsparacio mentioned this issue Apr 26, 2016
Closed
@dsparacio dsparacio removed their assignment Apr 27, 2016
@davemevans davemevans mentioned this issue May 20, 2016
Closed
@davemevans davemevans changed the title My live stream show incorrect time info Live audio-only stream show incorrect time info May 24, 2016
@davemevans davemevans mentioned this issue May 24, 2016
Closed
@davemevans davemevans mentioned this issue Jun 15, 2016
Merged
@dsparacio
Copy link
Contributor

The isVideoTrackPresent helper could be used in onPlaybackTimeUpdated to fix

@dsparacio dsparacio self-assigned this Jun 15, 2016
@dsparacio
Copy link
Contributor

@bbcrddave going to try to fix this today unless you already looked at it. Ping me if so.

@davemevans
Copy link
Contributor

I'll catch you on slack in an hour or so unless you put a PR in before then 😉

dsparacio pushed a commit to dsparacio/dash.js that referenced this issue Jun 15, 2016
Fix for issue Dash-Industry-Forum#887
94f4ede
dsparacio pushed a commit that referenced this issue Jun 15, 2016
Merge pull request #1454 from AkamaiDASH/development
235f38d 
Fix for issue #887
@dsparacio
Copy link
Contributor

Fixed with PR #1454

marcoslhc added a commit to veo-televisa/dash.js that referenced this issue Jul 19, 2016
@marcoslhc
Merge branch 'master' of https://github.com/Dash-Industry-Forum/dash.js…
3859753 
… into DC-7-create-test-cases-for-blim-env

* 'master' of https://github.com/Dash-Industry-Forum/dash.js: (97 commits)
  adding dist files to master
  Adding release notes to Reference player.
  Adding release notes to Reference player.
  Fix Dash-Industry-Forum#521 - properly support path-absolute BaseURLs
  Revert "For SegmentTemplate, only include available segments in DVRInfo"
  fix Dash-Industry-Forum#1463 - update documentation for setScheduleWhilePaused
  use sidx exclusively if there is an indexRange - thanks @bwidtmann
  Enable SegmentTimeline within SegmentList
  ManifestModel setValue should not trigger MANIFEST_LOADED when reset
  Update ISSUE_TEMPLATE.md
  Dash-Industry-Forum#1145 cleanup protection log
  Fix for issue Dash-Industry-Forum#887
  Removed build artifacts
  Reverted grunt changes
  Added support for filtering out key systems when no protection data for that key system is present
  fixed audio only buffer targets for longform etc...
  added missing comma
  fix for failing end test in browserstack
  Dash-Industry-Forum#1445 add a robustness level capabilities configuration for the protection controller. This is optional for Widevine Chrome to prevent robustness level warnings.
  remove check on required quality / check not needed anymore. See Dash-Industry-Forum#1443
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsparacio dsparacio

Labels
Bug Pri-High
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
3 participants
@davemevans @dsparacio @yancey918