Remove unused functions or parameters #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosang
force-pushed
the
removeUnusedParameter
branch
from
b6999ca
to
b5136df
Compare
nicosang
changed the title
nicosang
force-pushed
the
removeUnusedParameter
branch
from
982a4cc
to
3f401a9
Compare
nicosang
force-pushed
the
removeUnusedParameter
branch
2 times, most recently
from
a2a2443
to
aa3de2a
Compare
davemevans
reviewed
Jun 7, 2017
src/dash/models/DashManifestModel.js
Outdated
| return hasProfile(manifest, 'urn:mpeg:dash:profile:isoff-on-demand:2011'); | ||
| } | ||
|
|
||
| function getIsDVB(manifest) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Sorry, I'm not well awake...i did a revert on this last commit.
nicosang
force-pushed
the
removeUnusedParameter
branch
2 times, most recently
from
9d3a48c
to
4ddf2fa
Compare
In my opinion, if a function is only used in test unit file, it has to be deleted.
… used." This reverts commit ad56de8.
In my opinion, if a function is only used in test unit file, it has to be deleted.
nicosang
force-pushed
the
removeUnusedParameter
branch
from
5dac9ae
to
e4b1d69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.