Custom Abr Rules v2 #2057
Merged
Custom Abr Rules v2 #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utside the dash.js : it's neccessary when the different modules are used instead of the dash.all.
nicosang
force-pushed
the
add_factoryMaker_as_module
branch
from
5789a71
to
d6d6ffa
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in the previous PR #1846, @jeremco has introduced the ability to overide abr rules outside of dash.js. It works well when the dash.all is used, it doesn't when the different modules are used.
So, I suggest that we add a factorymaker module in order to be able to overload the rules outside the dash.js.
Nicolas