Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FactoryMaker exports #2081

Conversation

jeremco
Copy link
Contributor

@jeremco jeremco commented Jul 12, 2017

HI

PR #2057 was not sufficient to export FactoryMaker instance (using a module, 2 different instances were created). The idea here, is to export FactoryMaker directly in module mediaplayer, so that, there is only one instance of FactoryMaker.

This PR also updates sample custom ABR rules

Jérémie

The FactoryMaker is exported in mediaplayer module, it is not a separated module
@dsparacio dsparacio merged commit b530685 into Dash-Industry-Forum:development Aug 10, 2017
@nicosang nicosang deleted the factorymaker_exports branch August 11, 2017 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants