Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BufferController isBufferingComplete cleared on seeking #2128

Merged
merged 1 commit into from
Aug 18, 2017
Merged

BufferController isBufferingComplete cleared on seeking #2128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/streaming/controllers/BufferController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ function BufferController(config) {
isAppendingInProgress,
isPruningInProgress,
initCache,
seekStartTime;
seekStartTime,
seekClearedBufferingCompleted;

function setup() {
log = Debug(context).getInstance().log.bind(instance);
Expand Down Expand Up @@ -237,8 +238,11 @@ function BufferController(config) {
// START Buffer Level, State & Sufficiency Handling.
//**********************************************************************
function onPlaybackSeeking() {
lastIndex = Number.POSITIVE_INFINITY;
isBufferingCompleted = false;
if (isBufferingCompleted) {
seekClearedBufferingCompleted = true;
isBufferingCompleted = false;
maxAppendedIndex = 0;
}
seekStartTime = undefined;
onPlaybackProgression();
}
Expand Down Expand Up @@ -289,6 +293,12 @@ function BufferController(config) {
// No need to check buffer if type is not audio or video (for example if several errors occur during text parsing, so that the buffer cannot be filled, no error must occur on video playback)
if (type !== 'audio' && type !== 'video') return;

if (seekClearedBufferingCompleted && !isBufferingCompleted && playbackController && playbackController.getTimeToStreamEnd() - bufferLevel < STALL_THRESHOLD) {
seekClearedBufferingCompleted = false;
isBufferingCompleted = true;
eventBus.trigger(Events.BUFFERING_COMPLETED, {sender: instance, streamInfo: streamProcessor.getStreamInfo()});
}

if (bufferLevel < STALL_THRESHOLD && !isBufferingCompleted) {
notifyBufferStateChanged(BUFFER_EMPTY);
} else {
Expand Down Expand Up @@ -488,6 +498,7 @@ function BufferController(config) {
isBufferingCompleted = false;
isAppendingInProgress = false;
isPruningInProgress = false;
seekClearedBufferingCompleted = false;
bufferLevel = 0;
wallclockTicked = 0;

Expand Down