Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferController isBufferingComplete cleared on seeking #2128

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

spiterikevin
Copy link
Contributor

When the last segment is buffered, BufferController sets isBufferingComplete. If there is a seek after that time, isBufferingComplete was being cleared and never set again. When the player is eventually allowed to play the end of the stream, it incorrectly triggers a BUFFER_EMPTY event.

@dsparacio dsparacio merged commit 9995b48 into Dash-Industry-Forum:development Aug 18, 2017
@spiterikevin spiterikevin deleted the 1901a branch August 18, 2017 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants