Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wp testing #8

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Wp testing #8

merged 6 commits into from
Feb 14, 2024

Conversation

macpijan
Copy link

No description provided.

@macpijan macpijan mentioned this pull request Sep 21, 2022
Open
@macpijan macpijan changed the base branch from wp-detection to wp_integration September 21, 2022 09:25
SergiiDmytruk
SergiiDmytruk reviewed Sep 21, 2022
View reviewed changes
Documentation/chips.md Outdated Show resolved Hide resolved
Documentation/chips.md Outdated Show resolved Hide resolved
@macpijan
Copy link
Author

@SergiiDmytruk Added results for MX25L6436E/MX25L6445E/MX25L6465E as well

@macpijan
Copy link
Author

Also added W25Q64.W

@macpijan
Copy link
Author

@SergiiDmytruk any more comments?

coreboot-org-bot pushed a commit to flashrom/flashrom that referenced this pull request Oct 23, 2022
@SergiiDmytruk
flashchips.c: mark WP of 9 entries as tested
bd8a02d 
This is based on information from:
 * commit a850fd0
   - GD25LQ128C/GD25LQ128D/GD25LQ128E
   - GD25LQ64(B)
   - GD25Q127C/GD25Q128C
   - GD25Q256D/GD25Q256E
   - GD25Q64(B)
 * commit a8204dd
   - GD25Q32(B)
 * commit 7b4c4f3
   - W25Q64BV/W25Q64CV/W25Q64FV
 * Dasharo/dasharo-issues#67
   - W25Q128.V..M
 * Dasharo#8
   - W25Q64.W

Change-Id: I090188bad568885f78778e7fc7d8dbe20fb2445f
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Tested-by: Nikolai Artemiev <nartemiev@google.com>
Tested-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Tested-by: Kamil Pokornicki <kamil.pokornicki@3mdeb.com>
Tested-by: Przemyslaw Banasiak <przemyslaw.banasiak@3mdeb.com>
Tested-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/68180
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
coreboot-org-bot pushed a commit to flashrom/flashrom that referenced this pull request Nov 19, 2022
@SergiiDmytruk
flashchips.c: enable WP for 7 entries of MX chips
56ebda5 
These weren't split:
 * MX25L3206E/MX25L3208E
   Tested: Dasharo#8
 * MX25L6405
 * MX25L6405D
 * MX25L6406E/MX25L6408E
   Tested: Dasharo#8

MX25L6436E/MX25L6445E/MX25L6465E/MX25L6473E/MX25L6473F was split into:
 * MX25L6436E/MX25L6445E/MX25L6465E
   - security register
   - WPS
   - tested: Dasharo#8
 * MX25L6473E
   - security register
   - OTP TB bit in CONFIG/STATUS2 (0x15 opcode)
   - WPS
 * MX25L6473F
   - NO security register
   - OTP TB bit in CONFIG/STATUS2 (0x15 opcode)
   - NO WPS

Change-Id: Ib3db9d39ffacd3e9e44de92c6cfb6c3ecc8615bd
Tested-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/66216
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
@Disctanger
Copy link

I can confirm that MX25L3206E chip can be flashed using wp-testing branch.

Details of the flashing and context: flashrom#185 (comment)

@macpijan
MX25L3206E: add WP test report
10ea2ac 
Change-Id: I0f5a8f760660eae77e97c8b1a5c7dcf3dc6ba61d
Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
@macpijan
Documentation/chips.md: add test results table
94083d0 
Change-Id: I5c5811994b5bebeefd5be683208de8984ba281a3
Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
@macpijan
Documentation/MX25L6406E.md: add WP test report
16a8ada 
Change-Id: Iebef0e9d558dda75b469f467658e7f49e6e00224
Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
@macpijan
Docuemntation/MX25L6436E.md: add WP test reults
4487fb7 
Change-Id: Iffe0cc369251852874586745d04c7ce6b90dc87d
Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
@macpijan
Docuemntation/chips.md: add missing references
b387611 
Change-Id: I961e86053897164515e72ac20eebe7a46046b382
Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
@macpijan
Docuemntation/W25Q64.W.md: add WP test report
24c75c1 
Change-Id: I41f9561d2318162d5129f59c0f0d7964d110313e
Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
@macpijan macpijan merged commit 24c75c1 into wp_integration Feb 14, 2024
@macpijan macpijan deleted the wp-testing branch February 14, 2024 12:31
Sean-StarLabs pushed a commit to StarLabsLtd/flashrom that referenced this pull request Feb 20, 2024
@SergiiDmytruk @Sean-StarLabs
flashchips.c: enable WP for 7 entries of MX chips
c4770d4 
These weren't split:
 * MX25L3206E/MX25L3208E
   Tested: Dasharo#8
 * MX25L6405
 * MX25L6405D
 * MX25L6406E/MX25L6408E
   Tested: Dasharo#8

MX25L6436E/MX25L6445E/MX25L6465E/MX25L6473E/MX25L6473F was split into:
 * MX25L6436E/MX25L6445E/MX25L6465E
   - security register
   - WPS
   - tested: Dasharo#8
 * MX25L6473E
   - security register
   - OTP TB bit in CONFIG/STATUS2 (0x15 opcode)
   - WPS
 * MX25L6473F
   - NO security register
   - OTP TB bit in CONFIG/STATUS2 (0x15 opcode)
   - NO WPS

Change-Id: Ib3db9d39ffacd3e9e44de92c6cfb6c3ecc8615bd
Tested-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/66216
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergiiDmytruk SergiiDmytruk SergiiDmytruk approved these changes

@sulewskiprzemyslaw sulewskiprzemyslaw Awaiting requested review from sulewskiprzemyslaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@macpijan @Disctanger @SergiiDmytruk