Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: random state should be reset to None after being set in smash #330

Closed
nghi-truyen opened this issue Sep 23, 2024 · 0 comments · Fixed by #331
Closed

BUG: random state should be reset to None after being set in smash #330

nghi-truyen opened this issue Sep 23, 2024 · 0 comments · Fixed by #331
Assignees
@nghi-truyen
Labels
bug Something isn't working
Milestone
Release v1.1.0

Comments

@nghi-truyen
Copy link
Member

nghi-truyen commented Sep 23, 2024 •
edited
Loading

The numpy seed should be set to None after setting a specified seed from several methods in smash. Otherwise, random state doesn't work properly in some cases, for example:

model.set_nn_parameters_weight(initializer="glorot_normal", random_state=0) #random seed set for NN1
model.optimize("ann") #NN2 is initialized with a specified seed from the first line instead of random one
@nghi-truyen nghi-truyen added this to the Release v1.1.0 milestone Sep 23, 2024
@nghi-truyen nghi-truyen self-assigned this Sep 23, 2024
@nghi-truyen nghi-truyen added the bug Something isn't working label Sep 23, 2024
@nghi-truyen nghi-truyen linked a pull request Sep 23, 2024 that will close this issue
FIX: reset random seed after setting random_state #331
Merged
@nghi-truyen nghi-truyen mentioned this issue Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nghi-truyen nghi-truyen

Labels
bug Something isn't working
Projects
None yet
Milestone
Release v1.1.0
Development

Successfully merging a pull request may close this issue.

FIX: reset random seed after setting random_state nghi-truyen/smash-dev
1 participant
@nghi-truyen