Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test #44

Closed
wants to merge 27 commits into from
Closed

test #44

wants to merge 27 commits into from

Conversation

hansadriaans
Copy link

Summary of Changes

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

kristenarmes and others added 27 commits June 1, 2022 11:28
@kristenarmes
feat: Use type metadata description get/update apis (#1876)
08bea6c 
* Use type metadata description get/update apis

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Adding python tests for tm description apis

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Minor changes from feedback

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Addressing PR comments

Signed-off-by: Kristen Armes <karmes@lyft.com>
@allisonsuarez
feat: Search Service Highlighting (#1856)
78dd856 
* feat: Search Service Highlighting

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* fixed unit test

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* put attrdict access in try in case of keyerror

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* stupid

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* ???

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* mock mathc

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* debug

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* all unit tests pass

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* cinf fix

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* check that request has highlights

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* implemented feedback

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* empty checks

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* updated format response tests anhd put them in utils test file

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* fixed all tests

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* mypy

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* isort

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* added another unit test

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* isort

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* major oopsie

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* some changes

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* updated test

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* latets pending marshmallow3-annotations bump

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* remove debugging line

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* isort

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* bumped marshmallow3-annotation to 1.1.0

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* typing extensions issue attempt to fix

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* had to convert sttrdict and lsit in the end

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* sort imports

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
feat: search highlighting UI (#1850)
8756312 
* feat: search highlighting UI

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* wip

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* functional for tables pending styling and other resources

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* some rewrite

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* functional highlighting

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* functional and cleaned up

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* added column descriptions

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* unit tests, feature description highlight and feedback fixes

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* betterer results updated

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* feature description highlight, fix of descriptions, unit tests, and lint

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* some feedback cleanup

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* reverted betterer changes

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* revert betterer

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* styling fixes

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* implemented all feedback from Amrcos

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* rewrote ResourceListItem as fuctional component

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* fixed betterer issues

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint fix

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* update unit tests

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* add highlight options to expected

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@mgorsk1
🎉 Init (#1884)
ac07553 
Signed-off-by: Mariusz Górski <gorskimariusz13@gmail.com>

Co-authored-by: at91mm <mariusz.gorski@ing.com>
@allisonsuarez
styling change (#1887)
e8fee8c 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@chonyy
Skip fastapi error version 0.76.* (#1891)
b37886d 
Signed-off-by: Tony Chou <tcheon8788@gmail.com>
@kristenarmes
feat: Adding expand all/collapse all functionality for nested columns (…
1204acc 
…#1888)

* Adding expand all/collapse all functionality for nested columns

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Updating icon and other PR comments

Signed-off-by: Kristen Armes <karmes@lyft.com>
@henridwyer
Relax pandas version requirements for databuilder (#1858)
2d8f969 
Signed-off-by: Henri Dwyer <dwyerh@gene.com>

Co-authored-by: Henri Dwyer <dwyerh@gene.com>
@kristenarmes
feat: Add clickable rows to table detail page and new expand/collapse…
76620f2 
… arrow icons (#1897)

* Add clickable rows to table detail page and new arrow icons

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Small fixes

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Bug fix and PR comments

Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes
fix: Various fixes to nested columns based on feedback (#1901)
8a22ce8 
* Various fixes to nested columns based on feedback

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Addressing PR comments

Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes
Updating tour feature to store wildcard path instead of the url to av…
991b07f 
…oid showing it more than once (#1904)

Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes
Fixing markdown for truncated column descriptions in the table (#1905)
7107864 
Signed-off-by: Kristen Armes <karmes@lyft.com>
@alanmcruickshank
Handle qualified tableau datasources more gracefully (#1869)
5727f30 
Signed-off-by: Alan <alanmcruickshank@gmail.com>
@ka1319
added amazon eventbridge extractor (#1881)
4a4531e 
Signed-off-by: Kian Ahrabian <kahrabian@yahoo.com>
@kristenarmes
Fixing markdown display to cover more multiline cases (#1906)
0bab32b 
Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes
feat: Enable new nested columns (#1907)
a2a082a 
* Enable new nested columns

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Updating the readme

Signed-off-by: Kristen Armes <karmes@lyft.com>
@allisonsuarez
feat: added addition fields config to publisher (#1898)
75b858e 
* feat: added optional published_by publishing metadata to nodes

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* bumped to 6.9.0

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* set default value for publish by to None

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* added quote around published by value

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* made publisher accept a dict of fields through config

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* autopep

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* r in wrong place

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* morel inting

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* rerun checks

* flake

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* isort

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@ozandogrultan
fix: Handle BigQuery 404s gracefully (#1913)
8b63f13 
* fix: Handle BigQuery 404s gracefully

Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>

* fix: Increase max-complexity threshold for _retrieve_tables

Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
@MrwanBaghdad
Bump databuilder (#1916)
10e62ff 
Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com>
@kristenarmes
Remove all old frontend parsing for nested columns (#1919)
50f4193 
Signed-off-by: Kristen Armes <karmes@lyft.com>
@xfiderek
docs: Improves the frontend documentation on announcements (#1921)
c723dd4 
* Fix typo in application_config.md

Signed-off-by: xfiderek <fiderekblazej@gmail.com>

* make documentation about announcements mor explicit

Signed-off-by: xfiderek <fiderekblazej@gmail.com>
@ozandogrultan
feat: Extract search results per page into a config variable (#1922)
23f68fa 
* feat: Extract search results per page into a config variable

Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>

* feat: Add config-utils test

Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
@allisonsuarez
feat: added ngram subfield with no stemming on ES mappings (#1895)
055f81a 
* feat: added addition subfield with no stemming on ES mappings

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint fix

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* added ngram subfield to mappings

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* comment

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* bump version

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* want unigrams for 1 word matches

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* made method static

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
chore: bumped databuilder to 6.11.0 (#1923)
0254c59 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@kristenarmes
feat: Sticky TabsComponent and Table headers (#1924)
8093039 
* Made the tabs component and the table details page table header both sticky

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Addressing PR comment and updating variable name

Signed-off-by: Kristen Armes <karmes@lyft.com>
@Owen-CH-Leung
feat: add get_lineage support for neptune backend (#1915)
0b39e4d 
* feat: add get_lineage support for neptune backend

Signed-off-by: owenlch <owen.leung2@gmail.com>

* Fix Failing CI

Signed-off-by: owenlch <owen.leung2@gmail.com>

* Fix failing CI

Signed-off-by: owenlch <owen.leung2@gmail.com>

* Fix import sequence & type hint

Signed-off-by: owenlch <owen.leung2@gmail.com>
@ozandogrultan
fix: Update bounds for databuilder google-auth versions (#1918)
fdf0f0a 
* fix: Update bounds for databuilder google-auth versions

Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>

* fix: Bump up databuilder version

Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>

* fix: Revert css change

Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone