Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable new nested columns #1907

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

kristenarmes
Copy link
Contributor

Signed-off-by: Kristen Armes karmes@lyft.com

Summary of Changes

This change enables the new nested columns. This will not change anything for those who have not configured the ComplexTypeTransformer to create TypeMetadata objects for their ColumnMetadatas.

For those that do have the transformer configured, the following changes will be available:

Tests

N/A

Documentation

Included details in the databuilder README about how to configure the ComplexTypeTransformer.

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Signed-off-by: Kristen Armes <karmes@lyft.com>
@boring-cyborg boring-cyborg bot added area:databuilder From databuilder folder area:all Related to all the project area:docs area:frontend From the Frontend folder labels Jun 21, 2022
@kristenarmes kristenarmes marked this pull request as ready for review June 21, 2022 20:28
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

databuilder/README.md Outdated Show resolved Hide resolved
Signed-off-by: Kristen Armes <karmes@lyft.com>
@dkunitsk dkunitsk merged commit a2a082a into amundsen-io:main Jun 21, 2022
@kristenarmes kristenarmes deleted the enable-new-nested-columns branch June 21, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:all Related to all the project area:databuilder From databuilder folder area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants