Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

βš—πŸ› [RUMF-1293] discard dead clicks when activity occurs on pointerdown #1979

Merged

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Jan 27, 2023

This ticket is part of an effort to improve dead clicks.

All three fixes are behind the dead_click_fixes and will be released together after some dogfooding.

Motivation

We observed that in some cases, click actions are flagged as "dead click" when the UI updates during "pointerdown" or "mousedown" events (happening before the "click" event).

Changes

With this PR, we'll observe page activity occuring during the "pointerdown" event, and will discard the "dead click" frustration if some activity occurs.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/frustration-signals--track-pointerdown-activity branch 2 times, most recently from 95dc3e5 to b5e1da4 Compare January 27, 2023 14:58
@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review January 30, 2023 09:01
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner January 30, 2023 09:01
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/frustration-signals--track-pointerdown-activity branch from 8dfe8ec to b5e1da4 Compare January 30, 2023 13:15
Base automatically changed from benoit/frustration-signals--track-pointerup to main January 30, 2023 13:56
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/frustration-signals--track-pointerdown-activity branch from b5e1da4 to 28207e3 Compare January 30, 2023 14:00
@BenoitZugmeyer BenoitZugmeyer merged commit bcd2cd7 into main Jan 30, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/frustration-signals--track-pointerdown-activity branch January 30, 2023 14:43
BenoitZugmeyer added a commit that referenced this pull request Feb 6, 2023
BenoitZugmeyer added a commit that referenced this pull request Feb 6, 2023
BenoitZugmeyer added a commit that referenced this pull request Feb 7, 2023
BenoitZugmeyer added a commit that referenced this pull request Feb 7, 2023
 pm_trace_id: 13144861
 feature_branch_pipeline_id: 13144861
 source: to-staging

* commit '6a98a9480c800aff92ce4c5d37270534623f7661':
  βœ… remove now unneeded experimental flag from e2e tests
  βœ…πŸ”₯ remove now unneeded clock mock in tests
  πŸš©πŸ› enable fix #1979
  πŸ”‡ remove pointerup_delay info for #1958
  πŸš©πŸ› enable fix #1958
  πŸš©πŸ› enable fix #1968
  πŸš©πŸ› enable fix #1986
BenoitZugmeyer added a commit that referenced this pull request Feb 10, 2023
* πŸš©πŸ› enable fix #1986

* πŸš©πŸ› enable fix #1968

* πŸš©πŸ› enable fix #1958

* πŸ”‡ remove pointerup_delay info for #1958

* πŸš©πŸ› enable fix #1979

* βœ…πŸ”₯ remove now unneeded clock mock in tests

* βœ… remove now unneeded experimental flag from e2e tests

* πŸ‘Œ rename `onStartEvent` to `onPointerUp`

* πŸ‘Œ rename startEvent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants