Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️🐛 ignore contenteditable elements for dead clicks #1986

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Jan 30, 2023

This ticket is part of an effort to improve dead clicks.

All fixes are behind the dead_click_fixes and will be released together after some dogfooding.

Motivation

When users are manipulating contenteditable elements, we often report dead clicks incorrectly

Changes

Ignore contenteditable elements for dead clicks.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/frustration-signals--ignore-contenteditable-for-dead-clicks branch from 7240711 to 1ab484f Compare January 30, 2023 18:27
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/frustration-signals--ignore-contenteditable-for-dead-clicks branch from 1ab484f to 8356e60 Compare January 30, 2023 18:33
@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review January 30, 2023 18:34
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner January 30, 2023 18:34
@codecov-commenter
Copy link

Codecov Report

Merging #1986 (8356e60) into main (5ad73a0) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1986      +/-   ##
==========================================
- Coverage   93.31%   93.24%   -0.08%     
==========================================
  Files         145      145              
  Lines        5502     5504       +2     
  Branches     1253     1255       +2     
==========================================
- Hits         5134     5132       -2     
- Misses        368      372       +4     
Impacted Files Coverage Δ
...n/rumEventsCollection/action/computeFrustration.ts 100.00% <100.00%> (ø)
...rum-core/src/domain/contexts/foregroundContexts.ts 90.76% <0.00%> (-6.16%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan changed the title 🐛 ignore contenteditable elements for dead clicks ⚗️🐛 ignore contenteditable elements for dead clicks Jan 31, 2023
@BenoitZugmeyer BenoitZugmeyer merged commit 43acd2e into main Jan 31, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/frustration-signals--ignore-contenteditable-for-dead-clicks branch January 31, 2023 11:13
BenoitZugmeyer added a commit that referenced this pull request Feb 6, 2023
BenoitZugmeyer added a commit that referenced this pull request Feb 6, 2023
BenoitZugmeyer added a commit that referenced this pull request Feb 7, 2023
BenoitZugmeyer added a commit that referenced this pull request Feb 7, 2023
 pm_trace_id: 13144861
 feature_branch_pipeline_id: 13144861
 source: to-staging

* commit '6a98a9480c800aff92ce4c5d37270534623f7661':
  ✅ remove now unneeded experimental flag from e2e tests
  ✅🔥 remove now unneeded clock mock in tests
  🚩🐛 enable fix #1979
  🔇 remove pointerup_delay info for #1958
  🚩🐛 enable fix #1958
  🚩🐛 enable fix #1968
  🚩🐛 enable fix #1986
BenoitZugmeyer added a commit that referenced this pull request Feb 10, 2023
* 🚩🐛 enable fix #1986

* 🚩🐛 enable fix #1968

* 🚩🐛 enable fix #1958

* 🔇 remove pointerup_delay info for #1958

* 🚩🐛 enable fix #1979

* ✅🔥 remove now unneeded clock mock in tests

* ✅ remove now unneeded experimental flag from e2e tests

* 👌 rename `onStartEvent` to `onPointerUp`

* 👌 rename startEvent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants