Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-1296][RUMF-1293] fix dead click computation #1998

Merged
merged 9 commits into from Feb 10, 2023

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Feb 6, 2023

Motivation

This PR enables various fixes related to dead click computation:

Changes

  • Remove experimental flags
  • Adjust tests

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer changed the title Benoit/enable dead click fixes 🐛 [RUMF-1296][RUMF-1293] fix dead click computation Feb 6, 2023
@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review February 7, 2023 17:01
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner February 7, 2023 17:01
@BenoitZugmeyer BenoitZugmeyer merged commit e23c1ed into main Feb 10, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/enable-dead-click-fixes branch February 10, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants