Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed lines miss issue when tailing new files #1315

Merged
merged 2 commits into from
Feb 21, 2018

Conversation

ajacquemot
Copy link
Contributor

What does this PR do?

Tail new files discovered when scanning from the beginning instead of the end.

Motivation

Fixed lines miss issue when tailing new files

Additional Notes

This PR solve this issue

@ajacquemot ajacquemot force-pushed the ajacquemot/logs_fix_tail_files_issue branch from 4ce8efa to 2f23f19 Compare February 21, 2018 11:03
Copy link
Contributor

@tmichelet tmichelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this should match our use cases and is simple

Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 feel free to merge

@ajacquemot ajacquemot merged commit fda87cb into master Feb 21, 2018
@ajacquemot ajacquemot deleted the ajacquemot/logs_fix_tail_files_issue branch February 21, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants