Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fleet) fix remote updates permissions #25170

Merged
merged 6 commits into from
Apr 26, 2024
Merged

Conversation

arbll
Copy link
Member

@arbll arbll commented Apr 26, 2024

Couple fixes to allow the deamon to write runtime files.

Couple fixes to allow the deamon to write runtime files.
@arbll arbll added changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/fleet-automation labels Apr 26, 2024
@arbll arbll requested a review from a team as a code owner April 26, 2024 09:19
Copy link
Contributor

@BaptisteFoy BaptisteFoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe a line on the E2E test?

@raphaelgavache
Copy link
Contributor

@pr-commenter
Copy link

pr-commenter bot commented Apr 26, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=33052707 --os-family=ubuntu

@pr-commenter
Copy link

pr-commenter bot commented Apr 26, 2024

Regression Detector

Regression Detector Results

Run ID: 1d6f39e3-b626-4a1d-ba8a-0007679bea63
Baseline: b725666
Comparison: bdfeb48

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -25.02 [-29.38, -20.67]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
basic_py_check % cpu utilization +2.53 [-0.06, +5.11]
tcp_syslog_to_blackhole ingress throughput +0.89 [-20.43, +22.20]
file_tree memory utilization +0.43 [+0.31, +0.56]
process_agent_real_time_mode memory utilization +0.29 [+0.24, +0.34]
process_agent_standard_check memory utilization +0.27 [+0.20, +0.34]
process_agent_standard_check_with_stats memory utilization +0.23 [+0.17, +0.29]
tcp_dd_logs_filter_exclude ingress throughput +0.04 [-0.01, +0.09]
otel_to_otel_logs ingress throughput +0.04 [-0.32, +0.39]
trace_agent_msgpack ingress throughput -0.00 [-0.01, -0.00]
trace_agent_json ingress throughput -0.01 [-0.02, +0.00]
uds_dogstatsd_to_api ingress throughput -0.02 [-0.22, +0.19]
idle memory utilization -0.27 [-0.32, -0.23]
pycheck_1000_100byte_tags % cpu utilization -0.38 [-5.14, +4.39]
uds_dogstatsd_to_api_cpu % cpu utilization -2.65 [-5.42, +0.11]
file_to_blackhole % cpu utilization -25.02 [-29.38, -20.67]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@arbll
Copy link
Member Author

arbll commented Apr 26, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 26, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Apr 26, 2024

🚂 MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

@arbll
Copy link
Member Author

arbll commented Apr 26, 2024

/status

@dd-devflow
Copy link

dd-devflow bot commented Apr 26, 2024

🚂 Devflow: /status

This merge request has been building for 1h.

MergeQueue status for DataDog/datadog-agent branch main

There are currently 5 merge request being processed:

There is 1 merge request in the queue:

There is 1 merge request waiting a review/check:

@dd-mergequeue dd-mergequeue bot merged commit 4c65fb2 into main Apr 26, 2024
199 of 200 checks passed
@dd-mergequeue dd-mergequeue bot deleted the arbll/fix-remote-updates branch April 26, 2024 22:15
@github-actions github-actions bot added this to the 7.54.0 milestone Apr 26, 2024
alexgallotta pushed a commit that referenced this pull request May 9, 2024
* (fleet) fix remote updates permissions

Couple fixes to allow the deamon to write runtime files.

* tests

* fx fun

* fix tests

* lol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/fleet-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants