(fleet) fix minor issues in the installer bootstrap #25267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues discovered during the rollout: - `/tmp` mounted as `noexec` => this PR moves the bootstraped installer to a tmp under `/opt/datadog-installer` - some customers are running the install script in a loop, we need to avoid re-bootstraping everytime (and later re-installing)
arbll
added
qa/done
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=33254649 --os-family=ubuntu |
arbll
added a commit
that referenced
this pull request
May 11, 2024
* fix(installer): Use gcr.io by default instead of public.ecr.aws (#25255) * (fleet) fix minor issues in the installer bootstrap (#25267) Two issues discovered during the rollout: - `/tmp` mounted as `noexec` => this PR moves the bootstraped installer to a tmp under `/opt/datadog-installer` - some customers are running the install script in a loop, we need to avoid re-bootstraping everytime (and later re-installing) * (fleet) use rootTmpDir for both MkdirTemp in the bootstrap * (fleet) use actual package size to check if we have enough disk space This PR uses the changes in DataDog/datadog-packages#11 to properly compute the required disk space to install a package. Previously we were requiring 3GiB for any package. * purge * update test * pass test * properly remove all with go * remove noisy warn * (fleet) fix a warn log in telemetry ``` 2024/05/03 08:04:57 Datadog Tracer v1.61.0 WARN: ddtrace/tracer: deprecated config WithServiceName should not be used with `WithService` or `DD_SERVICE`; integration service name will not be set. ``` * (fleet) default to US1 for the telemetry website when DD_SITE isn't set * fix missing bootstrap * quick fix --------- Co-authored-by: Baptiste Foy <baptiste.foy@datadoghq.com> Co-authored-by: Raphael Gavache <raphael.gavache@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues discovered during the rollout:
/tmpmounted asnoexec=> this PR moves the bootstraped installer to a tmp under/opt/datadog-installer