-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more error types to trigger retries #25827
Conversation
[Fast Unit Tests Report] On pipeline 34829470 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=34829470 --os-family=ubuntu |
Regression DetectorRegression Detector ResultsRun ID: 159f62ac-ea5c-4751-aa8a-be074e581633 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +13.31 | [-9.31, +35.93] |
➖ | basic_py_check | % cpu utilization | +1.08 | [-1.26, +3.42] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | +0.63 | [-4.08, +5.35] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.20, +0.20] |
➖ | trace_agent_json | ingress throughput | +0.00 | [-0.01, +0.01] |
➖ | trace_agent_msgpack | ingress throughput | -0.00 | [-0.00, +0.00] |
➖ | idle | memory utilization | -0.01 | [-0.05, +0.04] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.03 | [-0.07, +0.00] |
➖ | otel_to_otel_logs | ingress throughput | -0.19 | [-0.55, +0.16] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.80 | [-3.60, +2.00] |
➖ | file_tree | memory utilization | -1.79 | [-1.89, -1.68] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue Pull request added to the queue. This build is next! (estimated merge in less than 53m) Use |
What does this PR do?
This PR adds a few more scenarios to trigger retries in KMT. These new error types are taken from the list of errors on which other e2e tests trigger retries:
datadog-agent/test/new-e2e/pkg/utils/infra/retriable_errors.go
Line 22 in 9c7a03d
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes