Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more error types to trigger retries #25827

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

usamasaqib
Copy link
Contributor

@usamasaqib usamasaqib commented May 22, 2024

What does this PR do?

This PR adds a few more scenarios to trigger retries in KMT. These new error types are taken from the list of errors on which other e2e tests trigger retries:

func getKnownErrors() []knownError {

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@usamasaqib usamasaqib added changelog/no-changelog team/ebpf-platform qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels May 22, 2024
@usamasaqib usamasaqib added this to the 7.54.0 milestone May 22, 2024
@usamasaqib usamasaqib requested a review from a team as a code owner May 22, 2024 14:36
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 34829470 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@pr-commenter
Copy link

pr-commenter bot commented May 22, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=34829470 --os-family=ubuntu

@pr-commenter
Copy link

pr-commenter bot commented May 22, 2024

Regression Detector

Regression Detector Results

Run ID: 159f62ac-ea5c-4751-aa8a-be074e581633
Baseline: 9c7a03d
Comparison: 157f66c

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +13.31 [-9.31, +35.93]
basic_py_check % cpu utilization +1.08 [-1.26, +3.42]
pycheck_1000_100byte_tags % cpu utilization +0.63 [-4.08, +5.35]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
idle memory utilization -0.01 [-0.05, +0.04]
tcp_dd_logs_filter_exclude ingress throughput -0.03 [-0.07, +0.00]
otel_to_otel_logs ingress throughput -0.19 [-0.55, +0.16]
uds_dogstatsd_to_api_cpu % cpu utilization -0.80 [-3.60, +2.00]
file_tree memory utilization -1.79 [-1.89, -1.68]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@usamasaqib
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 23, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 53m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit d47c6d7 into main May 23, 2024
271 checks passed
@dd-mergequeue dd-mergequeue bot deleted the usama.saqib/kmt-retries branch May 23, 2024 08:06
@github-actions github-actions bot modified the milestones: 7.54.0, 7.55.0 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/ebpf-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants