-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e tests #25851
Fix e2e tests #25851
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25851 +/- ##
===========================================
- Coverage 45.03% 35.85% -9.18%
===========================================
Files 2314 15 -2299
Lines 266595 2468 -264127
===========================================
- Hits 120062 885 -119177
+ Misses 136975 1575 -135400
+ Partials 9558 8 -9550
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=34953817 --os-family=ubuntu |
Regression DetectorRegression Detector ResultsRun ID: 1d114438-9b6a-4ed7-9bc5-1ad95fb66768 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | pycheck_1000_100byte_tags | % cpu utilization | +0.65 | [-4.03, +5.33] |
➖ | idle | memory utilization | +0.17 | [+0.13, +0.22] |
➖ | otel_to_otel_logs | ingress throughput | +0.08 | [-0.30, +0.45] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.20, +0.20] |
➖ | trace_agent_json | ingress throughput | -0.00 | [-0.01, +0.01] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.04, +0.03] |
➖ | trace_agent_msgpack | ingress throughput | -0.01 | [-0.01, +0.00] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.97 | [-3.74, +1.80] |
➖ | file_tree | memory utilization | -1.36 | [-1.45, -1.26] |
➖ | basic_py_check | % cpu utilization | -2.01 | [-4.53, +0.51] |
➖ | tcp_syslog_to_blackhole | ingress throughput | -4.78 | [-25.12, +15.55] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue Pull request added to the queue. This build is next! (estimated merge in less than 59m) Use |
What does this PR do?
This PR aims to fix the e2e tests by updating the download policy cli command to reflect the changes from the download policies endpoint
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes