Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connector from manifest.yaml #27853

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

dineshg13
Copy link
Member

@dineshg13 dineshg13 commented Jul 22, 2024

What does this PR do?

To simplify BYOC, we are moving datadog connector to code path that ensures it is always included.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@dineshg13 dineshg13 added team/opentelemetry OpenTelemetry team qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels Jul 22, 2024
@dineshg13 dineshg13 added this to the 7.57.0 milestone Jul 22, 2024
@dineshg13 dineshg13 marked this pull request as ready for review July 22, 2024 23:13
@dineshg13 dineshg13 requested a review from a team as a code owner July 22, 2024 23:13
@dineshg13 dineshg13 requested review from ankitpatel96 and songy23 and removed request for ankitpatel96 July 22, 2024 23:13
@pr-commenter
Copy link

pr-commenter bot commented Jul 23, 2024

Regression Detector

Regression Detector Results

Run ID: bb3fe5b5-0252-4b0c-97c5-cb73fa40b481 Metrics dashboard Target profiles

Baseline: 1c7bb9a
Comparison: 905429c

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
uds_dogstatsd_to_api_cpu % cpu utilization +1.48 [+0.58, +2.38] Logs
idle memory utilization +0.09 [+0.06, +0.12] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] Logs
file_tree memory utilization -0.19 [-0.25, -0.12] Logs
otel_to_otel_logs ingress throughput -0.73 [-1.55, +0.08] Logs
pycheck_1000_100byte_tags % cpu utilization -0.78 [-5.46, +3.89] Logs
basic_py_check % cpu utilization -1.62 [-4.14, +0.90] Logs
tcp_syslog_to_blackhole ingress throughput -2.08 [-14.56, +10.40] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pr-commenter
Copy link

pr-commenter bot commented Jul 23, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=39852013 --os-family=ubuntu

Note: This applies to commit d910c71

@dineshg13
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jul 23, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 08d06d8 into main Jul 23, 2024
217 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dinesh.gurumurthy/move-datadog-connector branch July 23, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants