Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] add a CORE support rule filter #28134

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

safchain
Copy link
Contributor

@safchain safchain commented Aug 1, 2024

What does this PR do?

This allows to target rule only on platform supporting CORE

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@safchain safchain force-pushed the safchain/core-filter branch 2 times, most recently from c7b4c9c to 597e335 Compare August 2, 2024 07:50
@safchain safchain requested a review from a team as a code owner August 2, 2024 07:50
@pr-commenter
Copy link

pr-commenter bot commented Aug 2, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=40765033 --os-family=ubuntu

Note: This applies to commit 44721aa

@pr-commenter
Copy link

pr-commenter bot commented Aug 2, 2024

Regression Detector

Regression Detector Results

Run ID: 5c2bf6fb-5e04-4733-ab8a-fb454f54283d Metrics dashboard Target profiles

Baseline: 1039270
Comparison: 44721aa

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
uds_dogstatsd_to_api_cpu % cpu utilization +0.93 [+0.05, +1.82] Logs
idle memory utilization +0.83 [+0.79, +0.87] Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] Logs
otel_to_otel_logs ingress throughput -0.25 [-1.06, +0.56] Logs
basic_py_check % cpu utilization -0.26 [-2.87, +2.35] Logs
tcp_syslog_to_blackhole ingress throughput -0.29 [-13.02, +12.44] Logs
file_tree memory utilization -0.70 [-0.80, -0.60] Logs
pycheck_1000_100byte_tags % cpu utilization -0.90 [-5.61, +3.82] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@safchain
Copy link
Contributor Author

safchain commented Aug 2, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 2, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Aug 2, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit d746b10 into main Aug 2, 2024
224 of 232 checks passed
@dd-mergequeue dd-mergequeue bot deleted the safchain/core-filter branch August 2, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants