[status/GUI] Avoid displaying log file path if it's empty #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvaka
approved these changes
Apr 5, 2019
derekwbrown
approved these changes
Apr 5, 2019
olivielpeau
added
the
[deprecated] team/agent-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoid displaying log file path if it's empty.
Having an empty
log_fileentry in the config is actually the default, since unlike other config params the default isn't set onconfig.Datadog.Follow-up to #3200
Motivation
Avoid displaying an empty
Log Fileentry on the status page and GUI. We'll only display it if it was customized by the user.Additional Notes
A better fix would be to make it so that the
log_fileconfig option has a sane default value on the config struct, but it's a significant change that I don't want to do this late in the6.11.0release process.