-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-enable six build on CCI #3353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, feel free to merge once answered/addressed!
templates: | ||
job_template: &job_template | ||
docker: | ||
- image: datadog/datadog-agent-runner-circle:latest | ||
- image: datadog/datadog-agent-runner-circle:six |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: should be switched back to latest
at some point, either before or after merging depending on your plan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change latest
to point to what's six
now and remove the old Dockerfile in a dedicated PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(approving again)
What does this PR do?
Re-enable Six build and test on top of the original CI build&test pipeline
Notice
There's no change here to any of the
invoke
tasks, meaning that tests are run against the existing embedding strategy.