Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable six build on CCI #3353

Merged
merged 4 commits into from
Apr 23, 2019
Merged

re-enable six build on CCI #3353

merged 4 commits into from
Apr 23, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Apr 23, 2019

What does this PR do?

Re-enable Six build and test on top of the original CI build&test pipeline

Notice

There's no change here to any of the invoke tasks, meaning that tests are run against the existing embedding strategy.

@masci masci added changelog/no-changelog [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. labels Apr 23, 2019
@masci masci added this to the 6.12.0 milestone Apr 23, 2019
olivielpeau
olivielpeau previously approved these changes Apr 23, 2019
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, feel free to merge once answered/addressed!

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
templates:
job_template: &job_template
docker:
- image: datadog/datadog-agent-runner-circle:latest
- image: datadog/datadog-agent-runner-circle:six
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: should be switched back to latest at some point, either before or after merging depending on your plan

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change latest to point to what's six now and remove the old Dockerfile in a dedicated PR

Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(approving again)

@masci masci merged commit 7c7e1fe into master Apr 23, 2019
@masci masci deleted the massi/cci branch April 23, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants