Report SQL server correctly #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
August 4, 2014 14:30
The use may be limited because the metrics to collect are not specified on a per instance basis but between different versions of SQL Server, the method of collection may be different
type should not be used anymore because we based the choice on the db content
| ) | ||
| try: | ||
| cursor.execute(''' | ||
| select distinct counter_name |
There was a problem hiding this comment.
Should we use a constant for that instead of having the query in the middle of the code ?
|
Nice work Rudy 👍 |
added 2 commits
August 6, 2014 12:12
Constantify the query and remove use of type keyword
| # | ||
| # - name: sqlserver.clr.execution | ||
| # type: gauge | ||
| # counter_name: CLR Execution | ||
| # | ||
| # This counter has multiple instances assocaited with it and we're |
There was a problem hiding this comment.
Can you fix the "assocaited" while you're there ? :)
added 2 commits
August 7, 2014 09:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for the problem that @tmichelet was trying to fix with #968.
What the issue is: Most of the metrics we report from SQL Server are not reported correctly
How to fix it: Microsoft documentation explains how to do it properly. Each counter has associated with him a value
cntr_typeexplaining how to report it. We can read this value and report the metric accordingly. This is preferred to setting the report method in advance because some metrics may change type between different verisons / OSImplementation info: In order to not break existing setup of users, the "type" (rate, gauge, histogram) attributes in the config is supported and overwrite any determination that we do ourselves.
@tmichelet @conorbranagan if you want to take a look.