Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogstream aggregate should sum counters #253

Closed
conorbranagan opened this issue Nov 9, 2012 · 1 comment · Fixed by #255
Closed

Dogstream aggregate should sum counters #253

conorbranagan opened this issue Nov 9, 2012 · 1 comment · Fixed by #255
Assignees
Labels
Milestone

Comments

@conorbranagan
Copy link
Member

Right now if you submit a counter from dogstream it just sends that value multiple times for the same timestamp. It should sum across before sending the metric.

@ghost ghost assigned conorbranagan Nov 9, 2012
@charles-dyfis-net
Copy link
Contributor

To be a bit more clear --

checks.datadog.Dogstream._aggregate() takes the median value for each second, regardless of whether a value is a counter or a gauge.

Thus, a single packet sent to datadog can include multiple values for a counter (at different seconds); however, all but one value per second will be discarded -- whereas for a counter, the correct behavior is clearly to sum them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants