Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submit plain hostname and fqdn in startup payload #62

Closed
xcolour opened this issue May 31, 2012 · 4 comments
Closed

submit plain hostname and fqdn in startup payload #62

xcolour opened this issue May 31, 2012 · 4 comments
Assignees
@alq666
Milestone
2.2.25

Comments

@xcolour
Copy link
Contributor

xcolour commented May 31, 2012

right now we only submit the fqdn. we should post the regular hostname too so they all can be aliased.
@ghost ghost assigned alq666 May 31, 2012
@alq666
Copy link
Member

alq666 commented Jun 3, 2012

@xcolour how do you want them?

{ 'hostname': 'blah', 'fqdn': 'blah.domain.com'}

@xcolour
Copy link
Contributor Author

xcolour commented Jun 7, 2012

Let's do:

{ 'hostname': 'blah.domain.com', 'shortname': 'blah' }

That way we can stay consistent with the payload from the currently released version of the agent.

@alq666
Copy link
Member

alq666 commented Jun 7, 2012

Hmm I thought hostname in the agent is the result of socket.gethostname() which will return the short name.

https://github.com/DataDog/dd-agent/blob/master/checks/__init__.py#L236

@alq666 alq666 mentioned this issue Jun 8, 2012
Merged
@alq666 alq666 closed this as completed Jun 11, 2012
@alq666
Copy link
Member

alq666 commented Jun 11, 2012

2.2.25 is on prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alq666 alq666

Labels
None yet
Projects
None yet
Milestone
2.2.25
Development

No branches or pull requests
2 participants
@alq666 @xcolour