Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacktrace deobfuscation #372

Closed
AdamGrzybkowski opened this issue Sep 11, 2020 · 12 comments
Closed

Stacktrace deobfuscation #372

AdamGrzybkowski opened this issue Sep 11, 2020 · 12 comments
Assignees
Labels
enhancement New feature or request fixed
Milestone

Comments

@AdamGrzybkowski
Copy link

Do you support stack trace deobfuscation in the Datadog console? If yes, where should I upload the mapping file? If no, would you consider adding this(logging exceptions in the app that has R8 enabled is not very useful)?

@AdamGrzybkowski AdamGrzybkowski added the bug Something isn't working label Sep 11, 2020
@xgouchet
Copy link
Member

Hi @AdamGrzybkowski ,

Thanks a lot for reaching out to us on this topic. This is not yet supported, but it's indeed something we do want to address in the future. We'll update this issue as soon as this is something the SDK can do.

@xgouchet xgouchet self-assigned this Sep 11, 2020
@xgouchet xgouchet added enhancement New feature or request and removed bug Something isn't working labels Sep 11, 2020
@henningms
Copy link

Adding support for automatic crash reporting with support for symbols would be great. Right now we have to add another third-party SDK to cover that need.

@elisamalzoni
Copy link

Hello, what is the status on this issue? Still no support?

If not the Log Collection documentation is misleading:
image
https://docs.datadoghq.com/logs/log_collection/android/?tab=us

@XyrizTan
Copy link

XyrizTan commented Apr 13, 2021

Bumping this up, I've been experimenting on what to submit to variant name, SDK indicated BuildConfig.FLAVOR is enough but I'm not convinced since mapping files are generated to outputs/mapping/{variant}/mapping.txt (if my app had google/huawei flavors for example, it would be googleRelease and huaweiRelease), anyway setting both google and googleRelease on datadog sdk credentials yielded no deobfuscated error stacktrace on the dashboard (still obfuscated, contrary to what the docs say 🤷 )

@priyanshi-gupta
Copy link
Contributor

priyanshi-gupta commented Apr 23, 2021

Wanted to update that crash reporting, de-obfuscation and error tracking are now available for the android SDK. Read more about it in this blog post and get detailed instructions here.

@henningms
Copy link

Oh! Exciting. Will test asap 😁

@XyrizTan
Copy link

XyrizTan commented Apr 28, 2021

Hello @priyanshi-gupta, already tested by following the steps on our current release build, can you confirm if this works on the throwable (stack trace) we send in the Logger? Because from my testing, it still doesn't, is it the case that the de-obfuscation only works on Datadog crash reporting?

@xgouchet
Copy link
Member

@XyrizTan the deobfuscation only works for crashes or errors reported in the RUM product. Logs aren't deobfuscated.

@XyrizTan
Copy link

@XyrizTan the deobfuscation only works for crashes or errors reported in the RUM product. Logs aren't deobfuscated.

Any insight if this can be a part of the Datadog Android SDK roadmap? Since the SDK Logger methods take in a throwable, it seems to make sense to also deobfuscate the error objects passed to the logger.

@dnhyde
Copy link

dnhyde commented Apr 14, 2022

I use this plugin with Timber dd integration it would make a lot of sense to de-obfuscate the throwable stacktrace. I mean I would like to handle the crash but log it somewhere

@Doetheman
Copy link

Following up on this, will deobfuscating logs be on the roadmap?

@xgouchet
Copy link
Member

Hi @Doetheman , this is something we're considering, but it's not on our immediate roadmap yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed
Projects
None yet
Development

No branches or pull requests

8 participants