Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose DdLogs publicly #121

Closed
tshedor opened this issue May 12, 2022 · 2 comments · Fixed by #125
Closed

Expose DdLogs publicly #121

tshedor opened this issue May 12, 2022 · 2 comments · Fixed by #125
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tshedor
Copy link

tshedor commented May 12, 2022

Are you requesting automatic instrumentation for a framework or library? Please describe.

  • Framework or library name : datadog_flutter_plugin
  • Library type: client
  • Library version: 1.0.0-beta.1

Is your feature request related to a problem? Please describe.

We utilize a class to store our loggers, and we cannot use the DdLogs type when specifying a field of the class.

Describe the solution you'd like

DdLogs is a publicly exposed class in an export.

Describe alternatives you've considered

Importing a /src/ file, although this is not considered effective Dart.

@tshedor tshedor added the enhancement New feature or request label May 12, 2022
@fuzzybinary fuzzybinary added the good first issue Good for newcomers label May 12, 2022
@fuzzybinary
Copy link
Collaborator

Thanks for the feedback Tim!

This is definitely an issue, especially since DatadogSdk.createLogger returns a DdLogs object, it should likely be exposed at the top package level.

@fuzzybinary
Copy link
Collaborator

DdLogs should be exposed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants