Skip to content

Commit

Permalink
.gitlab/scripts: remove BenchmarkConcurrentTracing from CI benchmarks (
Browse files Browse the repository at this point in the history
…#1845)

We replace BenchmarkConcurrentTracing with BenchmarkTracerAddSpans, which
should provide more reliable benchmarks about the cost of starting spans.

BenchmarkConcurrentTracing is not a reliable test and seems to mostly end
up testing the contention characteristics of the system it's running on.
  • Loading branch information
knusbaum authored and katiehockman committed Jul 26, 2023
1 parent 3de2e03 commit c99254a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ variables:
INDEX_FILE: index.txt
KUBERNETES_SERVICE_ACCOUNT_OVERWRITE: dd-trace-go
FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY: "true"
BENCHMARK_TARGETS: "BenchmarkConcurrentTracing|BenchmarkStartSpan|BenchmarkSingleSpanRetention|BenchmarkOTelApiWithCustomTags|BenchmarkInjectW3C|BenchmarkExtractW3C"
BENCHMARK_TARGETS: "BenchmarkTracerAddSpans|BenchmarkStartSpan|BenchmarkSingleSpanRetention|BenchmarkOTelApiWithCustomTags|BenchmarkInjectW3C|BenchmarkExtractW3C"

include:
- ".gitlab/benchmarks.yml"
Expand Down
1 change: 0 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,3 @@ Some benchmarks will run on any new PR commits, the results will be commented in
#### Adding a new benchmark
To add additional benchmarks that should run for every PR, go to `.gitlab-ci.yml`.
Add the name of your benchmark to the `BENCHMARK_TARGETS` variable using pipe character separators.

0 comments on commit c99254a

Please sign in to comment.