.gitlab/scripts: remove BenchmarkConcurrentTracing from CI benchmarks #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarkConcurrentTracing is not a reliable test and seems to mostly end up testing the contention characteristics of the system it's running on. Instead we replace it with BenchmarkTracerAddSpans, which should provide more reliable benchmarks about the cost of starting spans.
BenchmarksBenchmark execution time: 2023-07-25 16:31:41 Comparing candidate commit 2a1e577 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics. |
ajgajg1134
approved these changes
Mar 29, 2023
knusbaum
force-pushed
the
knusbaum/change-benchmarks
branch
from
7d902f7
to
638d448
Compare
katiehockman
pushed a commit
that referenced
this pull request
Jul 26, 2023
…#1845) We replace BenchmarkConcurrentTracing with BenchmarkTracerAddSpans, which should provide more reliable benchmarks about the cost of starting spans. BenchmarkConcurrentTracing is not a reliable test and seems to mostly end up testing the contention characteristics of the system it's running on.
8 tasks
|
Please see #2590 (comment) for the downsides of this PR. I'm considering to revert it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We replace BenchmarkConcurrentTracing with BenchmarkTracerAddSpans, which should provide more reliable benchmarks about the cost of starting spans.
Motivation
BenchmarkConcurrentTracing is not a reliable test and seems to mostly end up testing the contention characteristics of the system it's running on.
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.