-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: update DataDog/sketches-go to 1.2.1 #1051
Conversation
Well, we've found our first direct dependency that's incompatible with This raises the question of whether we should continue to support Honestly, I'm surprised we've managed to keep as much backward-compatibility as we have for as long as we have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As far as go version support is concerned: I'm voting for only supporting Go versions that are officially supported by the Go team. People who want to use old Go versions can use old versions of dd-trace-go and we can add a table to the README that show what go versions work with what version of dd-trace-go.
If we ever get a customer that is unable to upgrade Go but still needs some dd-trace-go bug fixed in an old version, we could always backport a fix and make a minor release for them.
My bad, I thought this was mergeable but the question of supporting go1.12 is still opened here. |
cbf7f04
to
1c53df5
Compare
sketches-go@v1.0.0 contains some bugs which are fixed in v1.2.1 Fixes #1021
sketches-go@v1.0.0 contains some bugs which are fixed in v1.2.1
Fixes #1021