Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redigo] Pass along the options argument in TracedDial. #109

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

vlad-mh
Copy link
Contributor

@vlad-mh vlad-mh commented Aug 22, 2017

No description provided.

Copy link

@gabsn gabsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also do the change in the new contrib folder here: https://github.com/DataDog/dd-trace-go/blob/master/contrib/garyburd/redigo/redigo.go?

@vlad-mh vlad-mh force-pushed the vlad/fix-redigo-traced-dial branch from f32badf to 5915a29 Compare August 22, 2017 20:37
@vlad-mh vlad-mh merged commit bdaf086 into master Aug 23, 2017
@vlad-mh vlad-mh deleted the vlad/fix-redigo-traced-dial branch August 23, 2017 18:20
@palazzem palazzem added the bug unintended behavior that has to be fixed label Aug 28, 2017
@palazzem palazzem added this to the 0.5.1 milestone Aug 28, 2017
@palazzem palazzem modified the milestones: 0.6.0, 0.5.1 Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintended behavior that has to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants