Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[redigo] Pass along the options argument in TracedDial. #109

Merged
merged 1 commit into from
Aug 23, 2017
Merged

[redigo] Pass along the options argument in TracedDial. #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contrib/garyburd/redigo/redigo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ type traceParams struct {

// TracedDial takes a Conn returned by redis.Dial and configures it to emit spans with the given service name
func TracedDial(service string, tracer *tracer.Tracer, network, address string, options ...redis.DialOption) (redis.Conn, error) {
c, err := redis.Dial(network, address)
c, err := redis.Dial(network, address, options...)
addr := strings.Split(address, ":")
var host, port string
if len(addr) == 2 && addr[1] != "" {
Expand Down
2 changes: 1 addition & 1 deletion tracer/contrib/redigo/redigotrace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ type traceParams struct {

// TracedDial takes a Conn returned by redis.Dial and configures it to emit spans with the given service name
func TracedDial(service string, tracer *tracer.Tracer, network, address string, options ...redis.DialOption) (redis.Conn, error) {
c, err := redis.Dial(network, address)
c, err := redis.Dial(network, address, options...)
addr := strings.Split(address, ":")
var host, port string
if len(addr) == 2 && addr[1] != "" {
Expand Down