[tracer] increase span buffer from 10k to 100k #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ufoot
force-pushed
the
christian/spanbuf100k
branch
from
6eb63d1
to
0d7af1c
Compare
AlexJF
approved these changes
Dec 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10k is quite low, we already get some real-world use cases with more than that.
Also, the upcoming Ruby PR has a setting of 100k, so it would make sense to have them use the same value: https://github.com/DataDog/dd-trace-rb/pull/247/files#diff-7bbc8937db718dfbfe46ab70654b47ccR19