tracer: dual sampling, make sure priorities -1 and 2 are handled #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJF
previously approved these changes
Dec 27, 2017
| if priority >= 0 { | ||
| s.SetMetric(samplingPriorityKey, float64(priority)) | ||
| } | ||
| s.SetMetric(samplingPriorityKey, float64(priority)) |
There was a problem hiding this comment.
LGTM. Maybe add the -1 case to the method's comment?
ufoot
force-pushed
the
christian/dualsampling
branch
from
b3d4afe
to
57d20a6
Compare
gabsn
previously approved these changes
Jan 2, 2018
palazzem
reviewed
Jan 3, 2018
tracer/span.go
Outdated
| // SetSamplingPriority sets the sampling priority. | ||
| // Default is 0, any higher value is interpreted as a hint on | ||
| // how interesting this span is, and should be kept by the backend. | ||
| // SetSamplingPriority sets the sampling priority. Possible values are: |
There was a problem hiding this comment.
Can't we provide constants for these values?
gbbr
changed the title
gbbr
approved these changes
Jan 16, 2018
| // PriorityAutoReject informs the backend that a trace should be rejected and not stored. | ||
| // This is used by the builtin sampler. | ||
| PriorityAutoReject = 0 | ||
| // PriorityAutoReject informs the backend that a trace should be kept and not stored. |
There was a problem hiding this comment.
@ufoot Looks like the name here (PriorityAutoReject) doesn't match the description (PriorityAutoKeep)? Typo?
| // PriorityAutoReject informs the backend that a trace should be kept and not stored. | ||
| // This is used by the builtin sampler. | ||
| PriorityAutoKeep = 1 | ||
| // PriorityUserReject informs the backend that a trace should be kept and not stored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow usage of
-1as a priority sampling value,2was already handled, but negative values were blocked.