-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracer: dual sampling, make sure priorities -1 and 2 are handled #137
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package ext | ||
|
||
// Priority is a hint given to the backend so that it knows which traces to reject or kept. | ||
// In a distributed context, it should be set before any context propagation (fork, RPC calls) to be effective. | ||
|
||
const ( | ||
// PriorityUserReject informs the backend that a trace should be rejected and not stored. | ||
// This should be used by user code overriding default priority. | ||
PriorityUserReject = -1 | ||
// PriorityAutoReject informs the backend that a trace should be rejected and not stored. | ||
// This is used by the builtin sampler. | ||
PriorityAutoReject = 0 | ||
// PriorityAutoReject informs the backend that a trace should be kept and not stored. | ||
// This is used by the builtin sampler. | ||
PriorityAutoKeep = 1 | ||
// PriorityUserReject informs the backend that a trace should be kept and not stored. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ufoot And here |
||
// This should be used by user code overriding default priority. | ||
PriorityUserKeep = 2 | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -316,12 +316,8 @@ func (s *Span) Tracer() *Tracer { | |
} | ||
|
||
// SetSamplingPriority sets the sampling priority. | ||
// Default is 0, any higher value is interpreted as a hint on | ||
// how interesting this span is, and should be kept by the backend. | ||
func (s *Span) SetSamplingPriority(priority int) { | ||
if priority >= 0 { | ||
s.SetMetric(samplingPriorityKey, float64(priority)) | ||
} | ||
s.SetMetric(samplingPriorityKey, float64(priority)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM. Maybe add the -1 case to the method's comment? |
||
} | ||
|
||
// HasSamplingPriority returns true if sampling priority is set. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ufoot Looks like the name here (
PriorityAutoReject
) doesn't match the description (PriorityAutoKeep
)? Typo?