New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.gitlab: add trigger for benchmarks #1588

Merged

knusbaum merged 13 commits into main from knusbaum/trigger-benchmarks

Nov 18, 2022

Contributor

knusbaum commented Nov 17, 2022

What does this PR do?

This adds a trigger for the relenv benchmarks.

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
Changed code has unit tests for its functionality.
If this interacts with the agent in a new way, a system test has been added.


          .gitlab-ci: add trigger for benchmarks

486204b

knusbaum added this to the Triage milestone

knusbaum requested a review from a team as a code owner

November 17, 2022 19:19

knusbaum added 2 commits

November 17, 2022 13:25

fix

b2a0be5

fix

880a9be

knusbaum requested a review from a team

November 17, 2022 20:26

knusbaum force-pushed the knusbaum/trigger-benchmarks branch 2 times, most recently from 609750d to 6ee6eb6 Compare

November 17, 2022 21:13


          test2

6a3d6b7

knusbaum force-pushed the knusbaum/trigger-benchmarks branch from 6ee6eb6 to 6a3d6b7 Compare

November 17, 2022 22:00

This comment has been minimized.

Sign in to view


          Run benchmarks in local gitlab not downstream

4728e15

ajgajg1134 force-pushed the knusbaum/trigger-benchmarks branch from bc8c90d to 4728e15 Compare

November 18, 2022 19:15

ajgajg1134 added 2 commits

November 18, 2022 14:29


          Moved scripts to dir

1674cfd


          Skip s3 upload for now

b643ae5

This comment has been minimized.

Sign in to view


          Move benchmarking scripts into local dir

807c930

This comment has been minimized.

Sign in to view

ajgajg1134 added 2 commits

November 18, 2022 15:37


          Save a full report in the artifacts

b8f3882


          run benchmarks for 2sec each

927b01a

This comment has been minimized.

Sign in to view

ajgajg1134 added 2 commits

November 18, 2022 15:48


          remove comments from scripts

3087ac9


          Merge branch 'main' into knusbaum/trigger-benchmarks

b7a1e4c

knusbaum modified the milestones: Triage, v1.44.0

This comment has been minimized.

Sign in to view


          Add docs for benchmarks, only run on PRs

5737c9d

ajgajg1134 force-pushed the knusbaum/trigger-benchmarks branch from f489505 to 5737c9d Compare

November 18, 2022 20:59

knusbaum commented

View reviewed changes

Contributor Author

knusbaum left a comment

I approve.

ajgajg1134 approved these changes

View reviewed changes

Contributor

ajgajg1134 left a comment

Looks great! Whoever wrote this really knows their stuff ;)

knusbaum changed the title ~~.gitlab-ci: add trigger for benchmarks~~ .gitlab: add trigger for benchmarks

pr-commenter bot commented Nov 18, 2022

Benchmarks

Found 2 performance improvements and 0 performance regressions! Performance is the same for 4 cases.

knusbaum merged commit e9abbd9 into main

knusbaum deleted the knusbaum/trigger-benchmarks branch

November 18, 2022 21:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment