Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade golang.org/x/net #1747

Merged
merged 2 commits into from
Feb 21, 2023
Merged

go.mod: upgrade golang.org/x/net #1747

merged 2 commits into from
Feb 21, 2023

Conversation

katiehockman
Copy link
Contributor

@katiehockman katiehockman commented Feb 17, 2023

What does this PR do?

Upgrades golang.org/x/net from v.0.3.0 to v.0.7.0.

go get -u golang.org/x/net@v0.7.0
go mod tidy

Motivation

https://pkg.go.dev/vuln/GO-2022-1144
https://pkg.go.dev/vuln/GO-2023-1571

Describe how to test/QA your changes

Not needed.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@katiehockman katiehockman added this to the v1.48.0 milestone Feb 17, 2023
@katiehockman katiehockman changed the title go.mod upgrade golang.org/x/net GO-2022-1144 go.mod: upgrade golang.org/x/net GO-2022-1144 Feb 17, 2023
@katiehockman katiehockman changed the title go.mod: upgrade golang.org/x/net GO-2022-1144 go.mod: upgrade golang.org/x/net Feb 17, 2023
@katiehockman katiehockman marked this pull request as ready for review February 17, 2023 22:17
@katiehockman katiehockman requested a review from a team as a code owner February 17, 2023 22:17
@pr-commenter
Copy link

pr-commenter bot commented Feb 17, 2023

Benchmarks

Comparing candidate commit 46e3fcd in PR branch katiehockman/upgrade-mod with baseline commit e535330 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@Julio-Guerra
Copy link
Contributor

You can run the govulncheck workflow manually to check that we are good, but v0.4.0 has another vulnerability fixed in v0.7.0 😅 So we need an higher version.
Cf. https://github.com/DataDog/dd-trace-go/actions/runs/4222598141/jobs/7331293046 (actually called this time)

@knusbaum knusbaum merged commit 0ef937c into main Feb 21, 2023
@knusbaum knusbaum deleted the katiehockman/upgrade-mod branch February 21, 2023 15:14
Hellzy pushed a commit that referenced this pull request Feb 21, 2023
Hellzy added a commit that referenced this pull request Feb 21, 2023
Upgrades golang.org/x/net from v.0.3.0 to v.0.7.0.

See:
https://pkg.go.dev/vuln/GO-2022-1144
https://pkg.go.dev/vuln/GO-2023-1571

Co-authored-by: Katie Hockman <katie@hockman.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants