profiler: add tag to indicate whether execution tracing is enabled #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2023-06-09 13:03:58 Comparing candidate commit 62f2cc8 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
nsrip-dd
force-pushed
the
nick.ripley/add-exec-tracing-enabled-tag
branch
2 times, most recently
from
73530eb
to
05717e3
Compare
go_execution_trace_enabled indicates whether execution tracing is enabled, to distinguish between missing a trace because we don't collect them every profiling cycle from missing a trace because the feature isn't turned on. While we're here, add these extra tracing tags to the batch object that's built during the profiling cycle. We can't safely read the execution trace config during the uploading, because it can be modified concurrently by the profiler after #1978. It makes more sense to have the profiler add all the needed information, which it can do safely, so that the upload step can just deal with uploading.
nsrip-dd
force-pushed
the
nick.ripley/add-exec-tracing-enabled-tag
branch
from
05717e3
to
f058aed
Compare
|
|
felixge
previously approved these changes
Jun 8, 2023
To make non-user-facing tags like this easier to hide in the future.
felixge
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
go_execution_trace_enabledtag to uploaded profiles.Motivation
Indicate whether execution tracing is enabled, to distinguish between missing a
trace because we don't collect them every profiling cycle from missing a trace
because the feature isn't turned on.
While we're here, add these extra tracing tags to the batch object
that's built during the profiling cycle. We can't safely read the
execution trace config during the uploading, because it can be modified
concurrently by the profiler after #1978. It makes more sense to have
the profiler add all the needed information, which it can do safely, so
that the upload step can just deal with uploading.
Describe how to test/QA your changes
This PR includes a unit test.
Reviewer's Checklist