Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: fix opentelemetry dependency issue #2005

Merged
merged 2 commits into from
May 26, 2023
Merged

Conversation

knusbaum
Copy link
Contributor

@knusbaum knusbaum commented May 25, 2023

What does this PR do?

This bumps the version of an opentelemetry integration to avoid transitive dependency version issues.

Motivation

Smoke tests were failing, due to an otel package changing its API between v0 and v1:
https://github.com/DataDog/dd-trace-go/actions/runs/5084143708/jobs/9136056040

Describe how to test/QA your changes

Smoke tests pass now:
https://github.com/DataDog/dd-trace-go/actions/runs/5084446394/jobs/9136752127

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@knusbaum knusbaum requested a review from a team as a code owner May 25, 2023 20:47
@pr-commenter
Copy link

pr-commenter bot commented May 25, 2023

Benchmarks

Comparing candidate commit fbf9493 in PR branch knusbaum/otel-dep with baseline commit 638d6fd in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@katiehockman katiehockman merged commit e681ddd into main May 26, 2023
@katiehockman katiehockman deleted the knusbaum/otel-dep branch May 26, 2023 18:51
katiehockman pushed a commit that referenced this pull request Jun 6, 2023
This bumps the version of an opentelemetry integration to avoid transitive dependency version issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants