Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddtrace: removed outdated tag #2086

Merged
merged 1 commit into from
Jun 29, 2023
Merged

ddtrace: removed outdated tag #2086

merged 1 commit into from
Jun 29, 2023

Conversation

dianashevchenko
Copy link
Contributor

What does this PR do?

This tag is no longer used to propagate second part of the TraceID. It was supposed to be removed as the 128-bits work was integrated instead

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@dianashevchenko dianashevchenko requested a review from a team June 29, 2023 10:45
@pr-commenter
Copy link

pr-commenter bot commented Jun 29, 2023

Benchmarks

Benchmark execution time: 2023-06-29 10:53:33

Comparing candidate commit 61bfc27 in PR branch shevchenko/remove-outdated-tag with baseline commit ac8b4aa in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics.

@dianashevchenko dianashevchenko merged commit e5d2d28 into main Jun 29, 2023
50 checks passed
@dianashevchenko dianashevchenko deleted the shevchenko/remove-outdated-tag branch June 29, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmed-mez ahmed-mez ahmed-mez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dianashevchenko @ahmed-mez