-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: move to 1.19 for lowest supported version #2192
all: move to 1.19 for lowest supported version #2192
Conversation
Goland insisted persistently to update dependencies here.
BenchmarksBenchmark execution time: 2023-09-04 08:08:41 Comparing candidate commit 634dff5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
f614c4b
to
d059ae5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the GOEXPERIMENT vs GODEBUG update 🙏
FTR, we did another solution in https://github.com/DataDog/go-libddwaf/blob/main/.github/workflows/test.yml#L20-L25 but we're good for now, we'll align later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
What does this PR do?
Go 1.21 has been out for a few weeks. Time to update! Also, dd-trace-go is officially un-compilable in <1.18 due to some dependencies introducing features only present in 1.18.
This PR is blocked by #2150 as there is a breaking change in 1.21 that could lead to issues. Just to be sure, merging this PR will occur after the former is solved.Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!