Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump go version in smoke tests #2193

Merged
merged 1 commit into from
Aug 31, 2023
Merged

ci: bump go version in smoke tests #2193

merged 1 commit into from
Aug 31, 2023

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Bump the Go version used in smoke tests.

Motivation

The smoke test job has been failing since otel dropped support for Go 1.18. This is a small and risk-free change to fix the smoke tests.

A bigger PR to bump the Go versions in dd-trace-go will come up next #2192 (depends on #2150)

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ahmed-mez ahmed-mez requested a review from darccio August 31, 2023 12:37
@ahmed-mez ahmed-mez requested a review from a team as a code owner August 31, 2023 12:37
@ahmed-mez
Copy link
Contributor Author

Here is a smoke test run on this branch https://github.com/DataDog/dd-trace-go/actions/runs/6037403166/job/16381610844

@ahmed-mez ahmed-mez merged commit 5fda053 into main Aug 31, 2023
52 of 53 checks passed
@ahmed-mez ahmed-mez deleted the ahmed/smoke-test-go branch August 31, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants