-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiler: enable execution traces by default for go1.21+ #2226
profiler: enable execution traces by default for go1.21+ #2226
Conversation
BenchmarksBenchmark execution time: 2023-09-27 11:36:04 Comparing candidate commit 3cca387 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm waiting to merge this until another commit lands as I want to try out another merge queue thing for the document I'm writing about it. |
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 9m) you can cancel this operation by commenting your pull request with |
🚨 MergeQueue not able to merge the branch in the target branch Details
Error: PUT https://api.github.com/repos/DataDog/dd-trace-go/pulls/2226/merge: 405 5 of 5 required status checks are expected. [] FullStacktrace: If you need support, contact us on slack #ci-interfaces with those details! |
…on-tracing-by-default
What does this PR do?
Enable execution traces by default for go1.21+
Motivation
We've verified that this is safe and has no performance impact on our internal fleet. Let's allow all customers to enjoy this feature without having to figure out how to turn it on.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!