Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.56.1] opentelemery: finish a span with an error if one is provided #2281

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

darccio
Copy link
Member

@darccio darccio commented Oct 19, 2023

What does this PR do?

Cherrypicks #2279

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@darccio darccio requested a review from a team October 19, 2023 15:19
@pr-commenter
Copy link

pr-commenter bot commented Oct 19, 2023

Benchmarks

Benchmark execution time: 2023-10-19 15:32:53

Comparing candidate commit 76c5918 in PR branch dario.castane/v1.56.1-otel with baseline commit 5781af2 in branch release-v1.56.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@epot
Copy link

epot commented Oct 20, 2023

I am subscribing to this :).

@darccio darccio merged commit 8c3c500 into release-v1.56.x Oct 20, 2023
50 checks passed
@darccio darccio deleted the dario.castane/v1.56.1-otel branch October 20, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants