Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dd-trace-go macrobenchmark to CI pipeline #2285

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

igoragoli
Copy link
Contributor

@igoragoli igoragoli commented Oct 23, 2023

What does this PR do?

Introduces macrobenchmarks run by the Benchmarking Platform to dd-trace-go's CI pipeline.

Please read the following PR in the Benchmarking Platform repo, where all the information related to the construction and testing of the macrobenchmarks can be found: https://github.com/DataDog/benchmarking-platform/pull/33. This PR only includes these macrobenchmarks in dd-trace-go's CI pipeline.

Testing of the CI pipeline

CI jobs were run with the igoragoli/testing/add-go-macrobenchmark branch:

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Oct 23, 2023

Benchmarks

Benchmark execution time: 2023-10-25 13:55:37

Comparing candidate commit 92ad12a in PR branch igoragoli/add-go-macrobenchmark with baseline commit 1dd3dd4 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@igoragoli igoragoli marked this pull request as ready for review October 24, 2023 10:08
@igoragoli igoragoli requested review from a team as code owners October 24, 2023 10:08
@igoragoli igoragoli force-pushed the igoragoli/add-go-macrobenchmark branch from 86a9586 to 843f144 Compare October 24, 2023 10:11
@darccio darccio merged commit a95d449 into main Oct 25, 2023
52 checks passed
@darccio darccio deleted the igoragoli/add-go-macrobenchmark branch October 25, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants