Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/opentelemetry: Fixed setting a wrong span field (span.kind) #2334

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

dianashevchenko
Copy link
Contributor

What does this PR do?

Previously, we were setting span.type based on the span.kind attribute. Now, span.kind will map to span.kind.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@dianashevchenko dianashevchenko requested a review from a team November 6, 2023 15:56
@dianashevchenko dianashevchenko changed the title Fixed setting a wrong span field ddtrace/opentelemetry: Fixed setting a wrong span field (span.kind) Nov 6, 2023
@@ -9,6 +9,7 @@ import (
"context"
"encoding/binary"
"encoding/hex"
"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/ext"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard,prefix(gopkg.in/DataDog/dd-trace-go.v1),default (gci)

@pr-commenter
Copy link

pr-commenter bot commented Nov 6, 2023

Benchmarks

Benchmark execution time: 2023-11-06 16:14:17

Comparing candidate commit c9ab46f in PR branch shevchenko/fix-span-kind-test with baseline commit 6ec6751 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@dianashevchenko dianashevchenko enabled auto-merge (squash) November 6, 2023 16:35
@dianashevchenko
Copy link
Contributor Author

APM_TRACING_E2E_OTEL failing in system-tests, which is fixed in DataDog/system-tests#1796

@dianashevchenko dianashevchenko merged commit 403e56d into main Nov 7, 2023
49 of 51 checks passed
@dianashevchenko dianashevchenko deleted the shevchenko/fix-span-kind-test branch November 7, 2023 14:46
@darccio darccio restored the shevchenko/fix-span-kind-test branch November 16, 2023 16:30
@darccio darccio deleted the shevchenko/fix-span-kind-test branch November 16, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants