tracer: report rc capabilities for dynamic config #2369
Conversation
| // ASMTrustedIPs represents Trusted IPs through the ASM product | ||
| ASMTrustedIPs | ||
| // ASMApiSecuritySampleRate represents API Security sampling rate | ||
| ASMApiSecuritySampleRate | ||
| // APMTracingSampleRate represents the rate at which to sample traces from APM client libraries | ||
| APMTracingSampleRate | ||
| // APMTracingLogsInjection enables APM client libraries to inject trace ids into log records | ||
| APMTracingLogsInjection | ||
| // APMTracingHTTPHeaderTags enables APM client libraries to tag http header values to http server or client spans | ||
| APMTracingHTTPHeaderTags | ||
| // APMTracingCustomTags enables APM client to set custom tags on all spans | ||
| APMTracingCustomTags |
There was a problem hiding this comment.
The order of these capabilities matters that's why I had to add a few that aren't currently used. Each capability is defined by its rank in the list.
The full and detailed documentation for RC capabilities is internal, I can share it offline if the reviewer is interested.
There was a problem hiding this comment.
IIUC, our tracer only supports APMTracingSampleRate and APMTracingHTTPHeaderTags, but no APMTracingLogsInjection and APMTracingCustomTags. From the JIRA issue, it's not clear what is the support of the latter. Probably I'm missing context.
There was a problem hiding this comment.
APMTracingLogsInjection won't be supported since there is no automatic logs injection in Go. APMTracingCustomTags will be supported in future versions though.
BenchmarksBenchmark execution time: 2023-11-20 09:39:19 Comparing candidate commit 081036f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
| // ASMTrustedIPs represents Trusted IPs through the ASM product | ||
| ASMTrustedIPs | ||
| // ASMApiSecuritySampleRate represents API Security sampling rate | ||
| ASMApiSecuritySampleRate | ||
| // APMTracingSampleRate represents the rate at which to sample traces from APM client libraries | ||
| APMTracingSampleRate | ||
| // APMTracingLogsInjection enables APM client libraries to inject trace ids into log records | ||
| APMTracingLogsInjection | ||
| // APMTracingHTTPHeaderTags enables APM client libraries to tag http header values to http server or client spans | ||
| APMTracingHTTPHeaderTags | ||
| // APMTracingCustomTags enables APM client to set custom tags on all spans | ||
| APMTracingCustomTags |
There was a problem hiding this comment.
IIUC, our tracer only supports APMTracingSampleRate and APMTracingHTTPHeaderTags, but no APMTracingLogsInjection and APMTracingCustomTags. From the JIRA issue, it's not clear what is the support of the latter. Probably I'm missing context.
What does this PR do?
AIT-8976
Report the RC capabilities related to the APM_TRACING product used for dynamic configuration.
Motivation
Declare what features can be supported by the tracer. This is important to exclude unsupported features like automatic logs injection.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!