Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gotraceui to v0.3.0. #2443

Merged
merged 7 commits into from Dec 20, 2023
Merged

Conversation

darccio
Copy link
Contributor

@darccio darccio commented Dec 18, 2023

What does this PR do?

Upgrades gotraceui to v0.3.0, that supports Go 1.21 traces.

Motivation

Review and act on TODO comments as part of the cleanup for v2 release.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@darccio darccio added this to the Triage milestone Dec 18, 2023
@darccio darccio requested review from a team December 18, 2023 14:02
@darccio darccio requested a review from a team as a code owner December 18, 2023 14:02
@pr-commenter
Copy link

pr-commenter bot commented Dec 18, 2023

Benchmarks

Benchmark execution time: 2023-12-19 16:45:43

Comparing candidate commit d48ce66 in PR branch dario.castane/AIT-9184/gotraceui-v0.3.0 with baseline commit 4ae528b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@darccio darccio enabled auto-merge (squash) December 19, 2023 13:48
@darccio darccio merged commit c8cdbbb into main Dec 20, 2023
153 checks passed
@darccio darccio deleted the dario.castane/AIT-9184/gotraceui-v0.3.0 branch December 20, 2023 15:25
@darccio darccio restored the dario.castane/AIT-9184/gotraceui-v0.3.0 branch December 20, 2023 15:26
darccio added a commit that referenced this pull request Dec 20, 2023
@darccio darccio deleted the dario.castane/AIT-9184/gotraceui-v0.3.0 branch December 20, 2023 15:35
@darccio darccio changed the title AIT-9184: update gotraceui to v0.3.0. Update gotraceui to v0.3.0. Dec 20, 2023
@darccio
Copy link
Contributor Author

darccio commented Dec 20, 2023

Reverted and discarded. Reviewdog fails to run in this PR (example). I kind of reproduced locally running the lint job, but I have no simple way to debug:

act pull_request -e /tmp/pr-event.json -s GITHUB_TOKEN="$(gh auth token)" --container-architecture linux/amd64 --rm -j lint -W ./.github/workflows/unit-integration-tests.yml -P "APM Larger Runners"=catthehacker/ubuntu:act-22.04 --input github.head_ref=v2-dev --input github.base_ref=main --input ref=refs/pulls/2427/merge --input inputs.go-version=1.21

/tmp/pr-event.json looks like this:

{"number":2427}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants