New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gotraceui to v0.3.0. #2443
Conversation
BenchmarksBenchmark execution time: 2023-12-19 16:45:43 Comparing candidate commit d48ce66 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
Reverted and discarded. Reviewdog fails to run in this PR (example). I kind of reproduced locally running the lint job, but I have no simple way to debug: act pull_request -e /tmp/pr-event.json -s GITHUB_TOKEN="$(gh auth token)" --container-architecture linux/amd64 --rm -j lint -W ./.github/workflows/unit-integration-tests.yml -P "APM Larger Runners"=catthehacker/ubuntu:act-22.04 --input github.head_ref=v2-dev --input github.base_ref=main --input ref=refs/pulls/2427/merge --input inputs.go-version=1.21 /tmp/pr-event.json looks like this:
|
What does this PR do?
Upgrades
gotraceui
to v0.3.0, that supports Go 1.21 traces.Motivation
Review and act on TODO comments as part of the cleanup for v2 release.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!