Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gotraceui to v0.3.0. #2443

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Update gotraceui to v0.3.0. #2443

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
97e8f42
go.mod: update gotraceui to v0.3.0
darccio Dec 18, 2023
2c06c24
contrib/database/sql: remove build constraint for Go 1.21
darccio Dec 18, 2023
d1e435d
contrib/database/sql: add build constraint for Go 1.22
darccio Dec 18, 2023
7f4ac40
contrib/database/sql: improve build constraint comment
darccio Dec 18, 2023
af69b9f
Merge branch 'main' into dario.castane/AIT-9184/gotraceui-v0.3.0
darccio Dec 19, 2023
d48ce66
contrib/database/sql: isolate test to avoid import cycle
darccio Dec 19, 2023
b117980
contrib/database/sql: revert build tag to exclude 1.21
darccio Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions contrib/database/sql/exec_trace_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2023 Datadog, Inc.

// TODO: gotraceui does not currently handle Go 1.21 execution tracer changes,
// so we need to skip this test for that version. We still have coverage for
// older Go versions due to our support policy, and Go 1.21 shouldn't fundamentally
// change the behavior this test is covering. Remove this build constraint
// once gotraceui supports Go 1.21
// Each gotraceui does not handle next Go versions execution tracer changes,
// so we need to skip this test for future versions. We still have coverage for
// older Go versions due to our support policy, and Go 1.22 shouldn't fundamentally
// change the behavior this test is covering. Update this build constraint
// once gotraceui supports next Go version supported in our support policy.
//
//go:build !go1.21
darccio marked this conversation as resolved.
Show resolved Hide resolved
//go:build !go1.22

package sql

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ require (
gorm.io/driver/postgres v1.4.6
gorm.io/driver/sqlserver v1.4.2
gorm.io/gorm v1.25.3
honnef.co/go/gotraceui v0.2.0
honnef.co/go/gotraceui v0.3.0
k8s.io/apimachinery v0.23.17
k8s.io/client-go v0.23.17
)
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3021,8 +3021,8 @@ gotest.tools/gotestsum v1.8.2/go.mod h1:6JHCiN6TEjA7Kaz23q1bH0e2Dc3YJjDUZ0DmctFZ
gotest.tools/v3 v3.0.2/go.mod h1:3SzNCllyD9/Y+b5r9JIKQ474KzkZyqLqEfYqMsX94Bk=
gotest.tools/v3 v3.0.3/go.mod h1:Z7Lb0S5l+klDB31fvDQX8ss/FlKDxtlFlw3Oa8Ymbl8=
gotest.tools/v3 v3.3.0/go.mod h1:Mcr9QNxkg0uMvy/YElmo4SpXgJKWgQvYrT7Kw5RzJ1A=
honnef.co/go/gotraceui v0.2.0 h1:dmNsfQ9Vl3GwbiVD7Z8d/osC6WtGGrasyrC2suc4ZIQ=
honnef.co/go/gotraceui v0.2.0/go.mod h1:qHo4/W75cA3bX0QQoSvDjbJa4R8mAyyFjbWAj63XElc=
honnef.co/go/gotraceui v0.3.0 h1:+AAnS8W70Zg5LPNFprv0Vp47T1+n6wrHdUi3HFiLLGM=
honnef.co/go/gotraceui v0.3.0/go.mod h1:NSZZ7eph/Pw7oML0LB7bURivs55YCwgFPwU6fDsMR4A=
honnef.co/go/tools v0.0.0-20190102054323-c2f93a96b099/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
honnef.co/go/tools v0.0.0-20190106161140-3f1c8253044a/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
honnef.co/go/tools v0.0.0-20190418001031-e561f6794a2a/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
Expand Down